diff --git a/cmd/access_test.go b/cmd/access_test.go index 81c9f2b9..8810b6b3 100644 --- a/cmd/access_test.go +++ b/cmd/access_test.go @@ -13,9 +13,9 @@ func TestCLI_Access_Show(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, _, _, stderr := newTestApp() + app, _, stdout, _ := newTestApp() require.Nil(t, runAccessCommand(app, conf)) - require.Contains(t, stderr.String(), "user * (role: anonymous, tier: none)\n- no topic-specific permissions\n- no access to any (other) topics (server config)") + require.Contains(t, stdout.String(), "user * (role: anonymous, tier: none)\n- no topic-specific permissions\n- no access to any (other) topics (server config)") } func TestCLI_Access_Grant_And_Publish(t *testing.T) { @@ -30,7 +30,7 @@ func TestCLI_Access_Grant_And_Publish(t *testing.T) { require.Nil(t, runAccessCommand(app, conf, "ben", "sometopic", "read")) require.Nil(t, runAccessCommand(app, conf, "everyone", "announcements", "read")) - app, _, _, stderr := newTestApp() + app, _, stdout, _ := newTestApp() require.Nil(t, runAccessCommand(app, conf)) expected := `user phil (role: admin, tier: none) - read-write access to all topics (admin role) @@ -41,7 +41,7 @@ user * (role: anonymous, tier: none) - read-only access to topic announcements - no access to any (other) topics (server config) ` - require.Equal(t, expected, stderr.String()) + require.Equal(t, expected, stdout.String()) // See if access permissions match app, _, _, _ = newTestApp() diff --git a/cmd/tier_test.go b/cmd/tier_test.go index 145f273e..8ca2b768 100644 --- a/cmd/tier_test.go +++ b/cmd/tier_test.go @@ -12,21 +12,21 @@ func TestCLI_Tier_AddListChangeDelete(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, _, _, stderr := newTestApp() + app, _, stdout, _ := newTestApp() require.Nil(t, runTierCommand(app, conf, "add", "--name", "Pro", "--message-limit", "1234", "pro")) - require.Contains(t, stderr.String(), "tier added\n\ntier pro (id: ti_") + require.Contains(t, stdout.String(), "tier added\n\ntier pro (id: ti_") err := runTierCommand(app, conf, "add", "pro") require.NotNil(t, err) require.Equal(t, "tier pro already exists", err.Error()) - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTierCommand(app, conf, "list")) - require.Contains(t, stderr.String(), "tier pro (id: ti_") - require.Contains(t, stderr.String(), "- Name: Pro") - require.Contains(t, stderr.String(), "- Message limit: 1234") + require.Contains(t, stdout.String(), "tier pro (id: ti_") + require.Contains(t, stdout.String(), "- Name: Pro") + require.Contains(t, stdout.String(), "- Message limit: 1234") - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTierCommand(app, conf, "change", "--message-limit=999", "--message-expiry-duration=2d", @@ -40,18 +40,18 @@ func TestCLI_Tier_AddListChangeDelete(t *testing.T) { "--stripe-yearly-price-id=price_992", "pro", )) - require.Contains(t, stderr.String(), "- Message limit: 999") - require.Contains(t, stderr.String(), "- Message expiry duration: 48h") - require.Contains(t, stderr.String(), "- Email limit: 91") - require.Contains(t, stderr.String(), "- Reservation limit: 98") - require.Contains(t, stderr.String(), "- Attachment file size limit: 100.0 MB") - require.Contains(t, stderr.String(), "- Attachment expiry duration: 24h") - require.Contains(t, stderr.String(), "- Attachment total size limit: 10.0 GB") - require.Contains(t, stderr.String(), "- Stripe prices (monthly/yearly): price_991 / price_992") + require.Contains(t, stdout.String(), "- Message limit: 999") + require.Contains(t, stdout.String(), "- Message expiry duration: 48h") + require.Contains(t, stdout.String(), "- Email limit: 91") + require.Contains(t, stdout.String(), "- Reservation limit: 98") + require.Contains(t, stdout.String(), "- Attachment file size limit: 100.0 MB") + require.Contains(t, stdout.String(), "- Attachment expiry duration: 24h") + require.Contains(t, stdout.String(), "- Attachment total size limit: 10.0 GB") + require.Contains(t, stdout.String(), "- Stripe prices (monthly/yearly): price_991 / price_992") - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTierCommand(app, conf, "remove", "pro")) - require.Contains(t, stderr.String(), "tier pro removed") + require.Contains(t, stdout.String(), "tier pro removed") } func runTierCommand(app *cli.App, conf *server.Config, args ...string) error { diff --git a/cmd/token_test.go b/cmd/token_test.go index 03295081..456e53cd 100644 --- a/cmd/token_test.go +++ b/cmd/token_test.go @@ -14,28 +14,28 @@ func TestCLI_Token_AddListRemove(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTokenCommand(app, conf, "add", "phil")) - require.Regexp(t, `token tk_.+ created for user phil, never expires`, stderr.String()) + require.Regexp(t, `token tk_.+ created for user phil, never expires`, stdout.String()) - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTokenCommand(app, conf, "list", "phil")) - require.Regexp(t, `user phil\n- tk_.+, never expires, accessed from 0.0.0.0 at .+`, stderr.String()) + require.Regexp(t, `user phil\n- tk_.+, never expires, accessed from 0.0.0.0 at .+`, stdout.String()) re := regexp.MustCompile(`tk_\w+`) - token := re.FindString(stderr.String()) + token := re.FindString(stdout.String()) - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTokenCommand(app, conf, "remove", "phil", token)) - require.Regexp(t, fmt.Sprintf("token %s for user phil removed", token), stderr.String()) + require.Regexp(t, fmt.Sprintf("token %s for user phil removed", token), stdout.String()) - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runTokenCommand(app, conf, "list")) - require.Equal(t, "no users with tokens\n", stderr.String()) + require.Equal(t, "no users with tokens\n", stdout.String()) } func runTokenCommand(app *cli.App, conf *server.Config, args ...string) error { diff --git a/cmd/user_test.go b/cmd/user_test.go index e1bdd3ab..7a1d5378 100644 --- a/cmd/user_test.go +++ b/cmd/user_test.go @@ -15,20 +15,20 @@ func TestCLI_User_Add(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") } func TestCLI_User_Add_Exists(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") app, stdin, _, _ = newTestApp() stdin.WriteString("mypass\nmypass") @@ -41,10 +41,10 @@ func TestCLI_User_Add_Admin(t *testing.T) { s, conf, port := newTestServerWithAuth(t) defer test.StopServer(t, s, port) - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "--role=admin", "phil")) - require.Contains(t, stderr.String(), "user phil added with role admin") + require.Contains(t, stdout.String(), "user phil added with role admin") } func TestCLI_User_Add_Password_Mismatch(t *testing.T) { @@ -63,16 +63,16 @@ func TestCLI_User_ChangePass(t *testing.T) { defer test.StopServer(t, s, port) // Add user - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") // Change pass - app, stdin, _, stderr = newTestApp() + app, stdin, stdout, _ = newTestApp() stdin.WriteString("newpass\nnewpass") require.Nil(t, runUserCommand(app, conf, "change-pass", "phil")) - require.Contains(t, stderr.String(), "changed password for user phil") + require.Contains(t, stdout.String(), "changed password for user phil") } func TestCLI_User_ChangeRole(t *testing.T) { @@ -80,15 +80,15 @@ func TestCLI_User_ChangeRole(t *testing.T) { defer test.StopServer(t, s, port) // Add user - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") // Change role - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runUserCommand(app, conf, "change-role", "phil", "admin")) - require.Contains(t, stderr.String(), "changed role for user phil to admin") + require.Contains(t, stdout.String(), "changed role for user phil to admin") } func TestCLI_User_Delete(t *testing.T) { @@ -96,15 +96,15 @@ func TestCLI_User_Delete(t *testing.T) { defer test.StopServer(t, s, port) // Add user - app, stdin, _, stderr := newTestApp() + app, stdin, stdout, _ := newTestApp() stdin.WriteString("mypass\nmypass") require.Nil(t, runUserCommand(app, conf, "add", "phil")) - require.Contains(t, stderr.String(), "user phil added with role user") + require.Contains(t, stdout.String(), "user phil added with role user") // Delete user - app, _, _, stderr = newTestApp() + app, _, stdout, _ = newTestApp() require.Nil(t, runUserCommand(app, conf, "del", "phil")) - require.Contains(t, stderr.String(), "user phil removed") + require.Contains(t, stdout.String(), "user phil removed") // Delete user again (does not exist) app, _, _, _ = newTestApp() diff --git a/cmd/webpush_test.go b/cmd/webpush_test.go index 3c1de4f2..5a447831 100644 --- a/cmd/webpush_test.go +++ b/cmd/webpush_test.go @@ -10,17 +10,17 @@ import ( ) func TestCLI_WebPush_GenerateKeys(t *testing.T) { - app, _, _, stderr := newTestApp() + app, _, stdout, _ := newTestApp() require.Nil(t, runWebPushCommand(app, server.NewConfig(), "keys")) - require.Contains(t, stderr.String(), "Web Push keys generated.") + require.Contains(t, stdout.String(), "Web Push keys generated.") } func TestCLI_WebPush_WriteKeysToFile(t *testing.T) { tempDir := t.TempDir() t.Chdir(tempDir) - app, _, _, stderr := newTestApp() + app, _, stdout, _ := newTestApp() require.Nil(t, runWebPushCommand(app, server.NewConfig(), "keys", "--output-file=key-file.yaml")) - require.Contains(t, stderr.String(), "Web Push keys written to key-file.yaml") + require.Contains(t, stdout.String(), "Web Push keys written to key-file.yaml") require.FileExists(t, filepath.Join(tempDir, "key-file.yaml")) }