From 80462f7ee5f6c065267eabc6e88d18b714a7e4cb Mon Sep 17 00:00:00 2001 From: binwiederhier Date: Sat, 24 May 2025 08:58:44 -0400 Subject: [PATCH] Refine user API change --- server/server_admin.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/server/server_admin.go b/server/server_admin.go index 7c78adb3..92da1213 100644 --- a/server/server_admin.go +++ b/server/server_admin.go @@ -70,6 +70,7 @@ func (s *Server) handleUsersAdd(w http.ResponseWriter, r *http.Request, v *visit } return s.writeJSON(w, newSuccessResponse()) } + func (s *Server) handleUsersUpdate(w http.ResponseWriter, r *http.Request, v *visitor) error { req, err := readJSONWithLimit[apiUserAddOrUpdateRequest](r.Body, jsonBodyBytesLimit, false) if err != nil { @@ -96,16 +97,12 @@ func (s *Server) handleUsersUpdate(w http.ResponseWriter, r *http.Request, v *vi return err } } - var tier *user.Tier if req.Tier != "" { - tier, err = s.userManager.Tier(req.Tier) - if errors.Is(err, user.ErrTierNotFound) { + if _, err = s.userManager.Tier(req.Tier); errors.Is(err, user.ErrTierNotFound) { return errHTTPBadRequestTierInvalid } else if err != nil { return err } - } - if tier != nil { if err := s.userManager.ChangeTier(req.Username, req.Tier); err != nil { return err }