More manager tests

server/server.go

@@ -53,13 +53,7 @@ import (
 		rate limiting:
 		- login/account endpoints
 		Tests:
-		- APIs
-		- CRUD tokens
-		- Expire tokens
-		- userManager can be nil
 		- visitor with/without user
-		- userManager.<NEWSTUFF>
-
 		Later:
 		- Password reset
 		- Pricing
@@ -569,7 +563,7 @@ func (s *Server) handlePublishWithoutResponse(r *http.Request, v *visitor) (*mes
 		}
 	}
 	v.IncrMessages()
-	if v.user != nil {
+	if s.userManager != nil && v.user != nil {
 		s.userManager.EnqueueStats(v.user)
 	}
 	s.mu.Lock()
@@ -1342,7 +1336,7 @@ func (s *Server) sendDelayedMessages() error {
 	}
 	for _, m := range messages {
 		var v *visitor
-		if m.User != "" {
+		if s.userManager != nil && m.User != "" {
 			user, err := s.userManager.User(m.User)
 			if err != nil {
 				log.Warn("%s Error sending delayed message: %s", logMessagePrefix(v, m), err.Error())

server/server_account.go

@@ -8,7 +8,8 @@ import (
 )
 
 const (
-	jsonBodyBytesLimit = 4096
+	jsonBodyBytesLimit   = 4096
+	subscriptionIDLength = 16
 )
 
 func (s *Server) handleAccountCreate(w http.ResponseWriter, r *http.Request, v *visitor) error {
@@ -232,7 +233,7 @@ func (s *Server) handleAccountSubscriptionAdd(w http.ResponseWriter, r *http.Req
 		}
 	}
 	if newSubscription.ID == "" {
-		newSubscription.ID = util.RandomString(16)
+		newSubscription.ID = util.RandomString(subscriptionIDLength)
 		v.user.Prefs.Subscriptions = append(v.user.Prefs.Subscriptions, newSubscription)
 		if err := s.userManager.ChangeSettings(v.user); err != nil {
 			return err